fix(previewCleanup): Also cleanup the database #55729
Draft
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solracsf
requested review from
Altahrim,
come-nc,
provokateurin and
yemkareems
and removed request for
a team
8 tasks
|
|
||
| try { | ||
| // Delete preview folder | ||
| $previewFolder->delete(); |
There was a problem hiding this comment.
How does this not delete the filecache entries as well?
There was a problem hiding this comment.
Hum. It was my understanding that appdata folder is considered system-level storage, and not watched by the (user) cache updater? Am I wrong?
|
Tests need to be updated as well |
solracsf
added
2. developing
Signed-off-by: Git'Fellow <[email protected]>
solracsf
force-pushed
the
cleanPreviewDatabase
branch
from
8a275c3 to
ffca01a
Compare
|
This whole class needs to be rewritten for the new preview system. I'm going to do that tomorrow. Your work is still useful for the stable32 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #55709
Summary
Also delete database entries, not only the preview files
Checklist
3. to review, feature component)stable32)