fix(files): decrement quota by actual bytes written in stream_write #55731
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discovered while investigating random failures in the
QuotaTest
unit test.The problem:
$size
is set to the length of$data
after truncation.$this->limit
) is decremented by$size
before the actual write.fwrite()
, which may be more or less than$size
.If
fwrite()
writes fewer bytes than$size
(e.g., disk full), the quota will still be reduced by$size
, not the actual number written.Similarly, if it writes more (for example, if the underlying buffer had data in it), the returned value will be higher than expected.
The fix:
$written
) rather than the intended size.fwrite
writes fewer (or more, due to underlying buffering) bytes than requested.TODO
Checklist
3. to review
, feature component)stable32
)