feat: use task processing to send emails#55968
feat: use task processing to send emails#55968SebastianKrupinski wants to merge 1 commit intomasterfrom
Conversation
SebastianKrupinski
force-pushed
the
feat/task-processing-for-email
branch
2 times, most recently
from
2e53963 to
fa0c16e
Compare
SebastianKrupinski
added
3. to review
SebastianKrupinski
requested review from
Altahrim,
artonge,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team
| * | ||
| * @param array array representation of this object | ||
| */ | ||
| public function jsonDeserialize(array|string $data): void { |
There was a problem hiding this comment.
I would prefer a static function returning a new instance like https://github.com/nextcloud/mail/blob/1c24b8cf306f56ce5cbe2a86fb811a395ddd53fd/lib/Address.php#L32-L43 instead.
There was a problem hiding this comment.
Ah! yes, good point!
Done
| */ | ||
| interface JsonDeserializable { | ||
|
|
||
| public function jsonDeserialize(array|string $data): static; |
There was a problem hiding this comment.
I prefer a static method because the dynamic method needs object instantiation first. That is not an option for objects with required constructor arguments.
There was a problem hiding this comment.
I did that on purpose, to preserve DI functionality. If we use the static object building pattern, we can't inject any service a object might need like L10N.
So what would you prefer?
There was a problem hiding this comment.
The static method. Data objects should not use DI. DI is for services.
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
A bit unsure about static vs just using self but looks good otherwise 👍 
ChristophWurst
added
the
pending documentation
This change adds a new public API: the json deserialize interface. This means the developer documentation has to be extended. |
SebastianKrupinski
force-pushed
the
feat/task-processing-for-email
branch
2 times, most recently
from
b9116e9 to
17648f0
Compare
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
feat/task-processing-for-email
branch
from
17648f0 to
f158d33
Compare
3 participants
Summary
Checklist
3. to review, feature component)stable32)