-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(files): Do not fail on missing sidebar in files list #56138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3a08750 to
d9600e3
Compare
d9600e3 to
058dd55
Compare
058dd55 to
cd6fef0
Compare
|
/compile |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
/compile rebase |
When using richdocuments it was failing in case of shared links
or when user with opened file did a wheel click on a refresh page.
Then new tab appeared but instead opening the file it was doing
nothing (showing the list of files) or downloading the file.
Make code more defensive. I found these logs while debugging:
OCA.Files.Settings initialized
Sidebar.js:19 OCA.Files.Sidebar initialized
ShareSearch.js:16 OCA.Sharing.ShareSearch initialized
comments-app.js:15 OCA.Comments.View initialized
index.mjs:54 files: Error while opening sidebar Object
log @ index.mjs:54
index.mjs:54 files: Error while opening sidebar Objectapp: "files"
TypeError: window.OCA.Files.Sidebar.open is not a function
at h.exec (http://nc/dist/files-main.js?v=106d16db-0:1:70123)
at o.openSidebarForFile (http://nc/dist/files-main.js?v=106d16db-0:1:163422)
at o.handleOpenQueries (http://nc/dist/files-main.js?v=106d16db-0:1:163167)
at o.openDetails (http://nc/dist/files-main.js?v=106d16db-0:1:162349)
at fn (http://nc/dist/core-common.js?v=106d16db-0:1:3942538)
at e.run (http://nc/dist/core-common.js?v=106d16db-0:1:3946900)
at sa (http://nc/dist/core-common.js?v=106d16db-0:1:3948728)
at Array.<anonymous> (http://nc/dist/core-common.js?v=106d16db-0:1:3943585)
at bn (http://nc/dist/core-common.js?v=106d16db-0:1:3942986)level: 2uid: "admin"
[[Prototype]]: Object
log @ index.mjs:54
Possibly regression from
e700102
Fixes nextcloud/richdocuments#3815
Signed-off-by: Szymon Kłos <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
669c96e to
d41d3d1
Compare
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport dc3741a to stable32 |
|
/backport dc3741a to stable31 |
|
thank you very much for solving conflicts :) |
When using richdocuments it was failing in case of shared links or when user with opened file did a wheel click on a refresh page. Then new tab appeared but instead opening the file it was doing nothing (showing the list of files) or downloading the file.
Make code more defensive. I found these logs while debugging:
Possibly regression from
e700102
Fixes nextcloud/richdocuments#3815