refactor(template-manager): Modernize template manager API #56251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
carl/template-manager-cleanup
branch
2 times, most recently
from
f144421 to
8c12590
Compare
CarlSchwan
requested review from
come-nc,
leftybournes and
yemkareems
and removed request for
a team
CarlSchwan
force-pushed
the
carl/template-manager-cleanup
branch
from
8c12590 to
ed9cee1
Compare
provokateurin
approved these changes
Nov 17, 2025
come-nc
reviewed
Nov 17, 2025
come-nc
reviewed
Nov 24, 2025
lib/private/Files/Node/Folder.php
Outdated
Comment on lines
497
to
500
| $folder = $this->get(dirname($path)); | ||
| if (!($folder instanceof Folder)) { | ||
| throw new NotPermittedException("Unable to create folder $path. Parent is not a directory."); | ||
| } |
Contributor
There was a problem hiding this comment.
Does that work with a path like 'folderName'? dirname will return '.' and I’m not sure we handle that correctly in get().
Member
Author
There was a problem hiding this comment.
fixed and I added some unit tests
And correct openapi types for the size. Signed-off-by: Carl Schwan <[email protected]>
Allow to remove some boilerplate and also this new function is type safe. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/template-manager-cleanup
branch
from
61f0a5b to
9522dde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And correct openapi types for the size.
Summary
TODO
Checklist
3. to review, feature component)stable32)