Skip to content

fix(Memcache): use different cache key when in maintenance mode #56410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Memcache): use different cache key when in maintenance mode #56410

wants to merge 1 commit into from
+1 −1

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 12, 2025 •
edited
Loading

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Nov 12, 2025
@susnux susnux requested review from blizzz and danxuliu November 12, 2025 21:23
@susnux susnux requested a review from a team as a code owner November 12, 2025 21:23
@susnux susnux added the bug label Nov 12, 2025
@susnux susnux requested review from ArtificialOwl and icewind1991 and removed request for a team November 12, 2025 21:23
@susnux susnux added the 3. to review Waiting for reviews label Nov 12, 2025
@susnux susnux added the feature: caching Related to our caching system: scssCacher, jsCombiner... label Nov 12, 2025
@susnux
Copy link
Contributor Author

susnux commented Nov 12, 2025

/backport to stable32

come-nc
come-nc approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still differentiate maintenance and uninstalled?

@susnux
Copy link
Contributor Author

susnux commented Nov 13, 2025

Should we still differentiate maintenance and uninstalled?

What would be really nice would be to clear all caches when we discover a change between installation- or maintenance- states. But not sure that is safe as the APCu cache is shared between PHP apps (like different Nextcloud instances).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@danxuliu danxuliu Awaiting requested review from danxuliu

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: caching Related to our caching system: scssCacher, jsCombiner...

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux @come-nc