refactor(ServerVersion): Add missing type hinting #56491
Merged
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
added
3. to review
CarlSchwan
requested review from
ArtificialOwl,
icewind1991,
provokateurin and
yemkareems
and removed request for
a team
provokateurin
approved these changes
Nov 17, 2025
CarlSchwan
force-pushed
the
carl/type-version
branch
from
b662ff0 to
05c968f
Compare
susnux
approved these changes
Nov 17, 2025
And mark the class as consumable and readonly. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/type-version
branch
from
05c968f to
d4356e6
Compare
susnux
approved these changes
Nov 20, 2025
Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/type-version
branch
from
262d4f7 to
33d2664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
And mark the class as consumable and readonly.
Checklist
3. to review, feature component)stable32)