fix(files_sharing): Allow deleting a share of a missing file #56498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
Altahrim,
ArtificialOwl,
provokateurin and
salmart-dev
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
provokateurin
approved these changes
Nov 17, 2025
CarlSchwan
approved these changes
Nov 18, 2025
This can happen in various scenarios, we should allow the user to delete the share in this situation. Signed-off-by: Côme Chilliet <[email protected]>
Co-authored-by: Kate <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/fix-deleting-broken-shares
branch
from
76ed90b to
cc66d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This can happen in various scenarios, we should allow the user to delete the share in this situation.
See nextcloud/groupfolders#2827 for an example how this can happen. This PR does not fix the issue but at least allow users to delete the broken share to get out of the broken situation.
Checklist
3. to review, feature component)stable32)