Skip to content

fix(files_reminder): prevent setting reminder in the past #56520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2025
Merged

fix(files_reminder): prevent setting reminder in the past #56520

merged 2 commits into from
Nov 19, 2025
+160 −7

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 19, 2025 •
edited
Loading

Summary

Somehow it was missing..
If we send the following request:

PUT /ocs/v2.php/apps/files_reminders/api/v1/392 HTTP/1.1
Content-Type: application/json
OCS-APIREQUEST: true

{"dueDate":"2003-10-14T14:00:00.000Z"}

Then we see the observed response: 201 Created and the system shows a reminder message such as:
We will remind you of this file 22 years ago.

Checklist

@skjnldsv skjnldsv requested a review from a team as a code owner November 19, 2025 08:37
@skjnldsv skjnldsv requested review from ArtificialOwl, icewind1991, leftybournes and provokateurin and removed request for a team November 19, 2025 08:37
provokateurin
provokateurin approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗 ▶️ ⏲️

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 19, 2025

Adding tests ⌛

@skjnldsv skjnldsv self-assigned this Nov 19, 2025
@skjnldsv skjnldsv added this to the Nextcloud 33 milestone Nov 19, 2025
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 19, 2025
@skjnldsv skjnldsv merged commit dc97bc0 into master Nov 19, 2025
186 of 191 checks passed
@skjnldsv skjnldsv deleted the fix/past-reminder branch November 19, 2025 15:43
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 19, 2025

/backport to stable31

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 19, 2025

/backport to stable32

This was referenced Nov 19, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@nfebe nfebe nfebe approved these changes

@provokateurin provokateurin provokateurin approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

+1 more reviewer

@333ordogape333 333ordogape333 333ordogape333 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files_reminders

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv @ArtificialOwl @nfebe @provokateurin @333ordogape333