Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 20, 2025

Summary

  • Prerequirement: build: correct render build url in Vite for chunks/assets in dist #56554
  • Migrates the app to Vue 3
  • Vue 2 compatible changes are done in an individual commit, backportable
  • Dirty workarounds:
    • AccountMenuEntry is not fully compatible with Vue 3, expecting menu items to be replaced when mounted in place, not to be mounted inside the entry
      • Requires changes in core API to support it
    • User statuses are copied from user_status to core to avoid illegal import (core should not depend on an app)
    • Some box-sizing: border-box added

Checklist

@ShGKme ShGKme self-assigned this Nov 20, 2025
@ShGKme ShGKme force-pushed the chore/user_status--vue3 branch 2 times, most recently from fa9056c to b837912 Compare November 20, 2025 11:53
@ShGKme ShGKme added this to the Nextcloud 33 milestone Nov 20, 2025
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 20, 2025
@ShGKme ShGKme changed the base branch from master to fix/build-vite-chunks November 20, 2025 12:30
@ShGKme ShGKme force-pushed the chore/user_status--vue3 branch from b837912 to 5ca53f4 Compare November 20, 2025 12:31
@ShGKme ShGKme requested a review from Antreesy November 20, 2025 12:34
@ShGKme ShGKme force-pushed the fix/build-vite-chunks branch from 06cbc16 to d54009f Compare November 20, 2025 14:09
Base automatically changed from fix/build-vite-chunks to master November 20, 2025 23:17
@ShGKme ShGKme force-pushed the chore/user_status--vue3 branch 2 times, most recently from b78f534 to 2515803 Compare November 21, 2025 16:44
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 21, 2025

/compile

Signed-off-by: nextcloud-command <[email protected]>
@ShGKme ShGKme marked this pull request as ready for review November 21, 2025 17:44
@ShGKme ShGKme requested review from a team as code owners November 21, 2025 17:44
@ShGKme ShGKme requested review from nfebe and removed request for a team November 21, 2025 17:44
@ShGKme ShGKme requested review from Altahrim, CarlSchwan, sorbaugh and szaimen and removed request for a team November 21, 2025 17:44
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants