-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
perf: Prepend the app as a whole #56559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Joas Schilling <[email protected]>
|
Isnt this on purpose? For me this sounds like a different use case where we should maybe have a So before: use |
| // Make sure the scripts of prepended applications are prepended within the apps as well | ||
| $appDeps = self::$scriptDeps[$application] ?? []; | ||
| unset(self::$scriptDeps[$application]); | ||
| self::$scriptDeps = [$application => $appDeps] + self::$scriptDeps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the behavior from unshift a script in the list of your scripts (e.g. because you need specific order) to give your app higher priority over all other apps.
I do not think that is bad, but in that case please add a documentation string to the prepand attribute that it will prepand all scripts of that app in the global scripts list.
|
Then as said: I think this is a good change. |


Checklist
3. to review, feature component)stable32)