fix state for example content checkboxes #56562
Open
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
requested review from
nfebe and
susnux
and removed request for
a team
kesselb
requested review from
a team,
ChristophWurst,
GVodyanov,
hamza221 and
szaimen
and removed request for
ChristophWurst
susnux
reviewed
Nov 20, 2025
| <div class="example-contact-settings"> | ||
| <NcCheckboxRadioSwitch | ||
| :checked="enableDefaultContact" | ||
| :modelValue="enableDefaultContact" |
Contributor
There was a problem hiding this comment.
I wonder why the linter is not not red as props should be kebab-case
Suggested change
| :modelValue="enableDefaultContact" | |
| :model-value="enableDefaultContact" |
Contributor
There was a problem hiding this comment.
Warning: 9:4 warning Attribute ':modelValue' must be hyphenated vue/attribute-hyphenation
Warning: 12:4 warning v-on event '@update:modelValue' must be hyphenated vue/v-on-event-hyphenation
Collaborator
Author
There was a problem hiding this comment.
Should we add 'vue/v-on-event-hyphenation': 'error', to the eslint config?
kesselb
force-pushed
the
bug/noid/checked-state-for-example-content
branch
from
0f2b9e1 to
5adaac8
Compare
ChristophWurst
approved these changes
Nov 21, 2025
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bug/noid/checked-state-for-example-content
branch
from
5adaac8 to
6c7e27c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before: Check/Uncheck does not alter the state
After: It does
(in the screenshot contacts is fixed and events not to demo; pr fixes both)
Checklist
3. to review, feature component)stable32)