Skip to content

fix(user_ldap): Re-introduce easy login attributes checkboxes #56574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: artonge/debt/migrate_user_ldap_vu3
Choose a base branch
from
+15 −1
Open

fix(user_ldap): Re-introduce easy login attributes checkboxes #56574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea54f68
fix(user_ldap): Re-introduce easy login attributes checkboxes
artonge Nov 21, 2025
fbd3de9
fix(user_ldap): Use correct property to update login filter
artonge Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions apps/user_ldap/src/components/SettingsTabs/LoginTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,20 @@
{{ t('user_ldap', 'When logging in, {instanceName} will find the user based on the following attributes:', { instanceName }) }}
</legend>

<NcCheckboxRadioSwitch
:model-value="ldapConfigProxy.ldapLoginFilterUsername === '1'"
:description="t('user_ldap', 'Allows login against the LDAP/AD username, which is either \'uid\' or \'sAMAccountName\' and will be detected.')"
@update:model-value="ldapConfigProxy.ldapLoginFilterUsername = $event ? '1' : '0'">
{{ t('user_ldap', 'LDAP/AD Username:') }}
</NcCheckboxRadioSwitch>

<NcCheckboxRadioSwitch
:model-value="ldapConfigProxy.ldapLoginFilterEmail === '1'"
:description="t('user_ldap', 'Allows login against an email attribute. \'mail\' and \'mailPrimaryAddress\' allowed.')"
@update:model-value="ldapConfigProxy.ldapLoginFilterEmail = $event ? '1' : '0'">
{{ t('user_ldap', 'LDAP/AD Email Address:') }}
</NcCheckboxRadioSwitch>

<div class="ldap-wizard__login__line ldap-wizard__login__login-attributes">
<NcSelect
v-model="ldapLoginFilterAttributes"
Expand Down
2 changes: 1 addition & 1 deletion apps/user_ldap/src/components/SettingsTabs/UsersTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ async function reloadFilters() {

const response2 = await callWizard('getUserLoginFilter', props.configId)
// Not using ldapConfig to avoid triggering the save logic.
ldapConfigs.value[props.configId]!.ldapLoginFilter = (response2.changes?.ldap_userlogin_filter as string | undefined) ?? ''
ldapConfigs.value[props.configId]!.ldapLoginFilter = (response2.changes?.ldap_login_filter as string | undefined) ?? ''
}
}

Expand Down
Loading