Skip to content

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 24, 2025

When date range or person filters were applied, providers that didn't support these filters were automatically disabled in the UI. This made the in-folder filter appear auto-applied and prevented users from searching non-compatible providers.

Remove automatic provider disabling logic from updateDateFilter(), applyPersonFilter(), and removeFilter(). Content filters now apply only to compatible providers via existing compatibility checks while keeping all providers available for selection.

When date range or person filters were applied, providers that didn't
support these filters were automatically disabled in the UI. This made
the in-folder filter appear auto-applied and prevented users from
searching non-compatible providers.

Remove automatic provider disabling logic from updateDateFilter(),
applyPersonFilter(), and removeFilter(). Content filters now apply only
to compatible providers via existing compatibility checks while keeping
all providers available for selection.
@nfebe nfebe requested a review from a team as a code owner November 24, 2025 14:09
@nfebe nfebe requested review from skjnldsv, sorbaugh and szaimen and removed request for a team November 24, 2025 14:09
@nfebe nfebe added 3. to review Waiting for reviews feature: search labels Nov 24, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team Nov 24, 2025
@nfebe nfebe requested review from artonge and susnux November 24, 2025 14:10
@susnux
Copy link
Contributor

susnux commented Nov 24, 2025

Not checked now but is it communicated to user?
So if I enable a filter and a non compatible provider is the filter de-activated or somehow shown as in-active?
I expect confusion of users if filters are selected but not applied because the provider does not support it, meaning the users should know that it is not applied.

@nfebe
Copy link
Contributor Author

nfebe commented Nov 24, 2025

Issue

When users apply date/person filters in unified search, these filters only work on providers that support them. Other providers still return unfiltered results (Previously we tried to avoid sending the search query to these providers at all and this PR will not remove that behavior).

Example: Search "photo" with "Last 7 days" filter

  • Files: Returns photos from last 7 days
  • Comments: Returns ALL comments with "photo" (ignores date filter)

Question

What's the expected behavior?

A) Current: Mixed results
Show both filtered and unfiltered results together

B) Hide incompatible
Only show results from providers that support the filter

C) Visual separation
Show all results but clearly mark which are filtered vs not

Any recommendation from @nextcloud/designers

Cc: @kra-mo

@nfebe
Copy link
Contributor Author

nfebe commented Nov 24, 2025

Not checked now but is it communicated to user?
So if I enable a filter and a non compatible provider is the filter de-activated or somehow shown as in-active?
I expect confusion of users if filters are selected but not applied because the provider does not support it, meaning the users should know that it is not applied.

Yes man you are on track! I was going to add a comment for designers, my initial solution was not to send these queries at all, it seems that might be problematic because the filter is an ad-on to the SEARCH QUERY.

So even though filters are meant to REDUCE results that are already VALID for the SEARCH QUERY in this case we are preventing a search completely for unsupported filters which makes it seem as though there are not results for the SEARCH QUERY to start with.

@szaimen szaimen removed their request for review November 24, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

3 participants