-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
WebAuthn / FIDO2 / 2fa: allow discoverable or non-discoverable passkeys #57151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WebAuthn / FIDO2 / 2fa: allow discoverable or non-discoverable passkeys #57151
Conversation
b70e65a to
9da50df
Compare
…oice - Let users choose during registration whether a passkey is stored as a discoverable credential; retry with the legacy flow if the authenticator can't do resident keys. - Simplify “Log in with a device”: a single field now accepts an optional login/email, using discoverable credentials when left empty and falling back gracefully otherwise. - Backend/WebAuthn services updated to handle optional usernames and return the credential source so the UID can be derived from the authenticator. Signed-off-by: swissbit-eis-admin <[email protected]>
9da50df to
6606ccb
Compare
Signed-off-by: swissbit-eis-admin <[email protected]>
Signed-off-by: swissbit-eis-admin <[email protected]>
…ical and more user centric wording Signed-off-by: swissbit-eis-admin <[email protected]>
Signed-off-by: swissbit-eis-admin <[email protected]>
|
@ChristophWurst can you give me feedback to my PR? The idea was to extend Passkey Support by discoverable credentials (new), keep existing functionality for existing password less login (keep) and rephrase the technical wording (webauthn) to a more standard user centric view (modified). Thank you. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Please refer to PR to stable32: #57154
Both have similar function
Summary
This allows user to register discoverable and non-discoverable FIDO2 passkeys in user settings.
If user tries to login with second factor and omits email login -> discoverable credential attempted
if user fills in email at login -> classic host side credentials are used.
TODO
Checklist
3. to review, feature component)stable32)