feat(storage): improve robustness + logging in Local::rmdir()
#57343
+81
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Besides code clean-up the biggest changes in behavior are:
rmdircall, which only failed indirectly (i.e. if byproducts were left around)Note that the old behavior remains the same in terms not aborting if any individual item generates an error. The main difference is that now we explicitly return
falseto indicate thermdir()operation may not have truly been 100% successful.P.S. My opinion is that
rmdir()at the storage level should immediately fail rather than continue, but that's a bigger change that should be unified across the storage implementations.P.P.S. Rate limiting logging would be nice in this area of code...
TODO
Checklist
3. to review, feature component)stable32)