Skip to content

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jan 5, 2026

Summary

Besides code clean-up the biggest changes in behavior are:

  • Returns false if any file/folder deletions fail
    • previous behavior: return value as tied to the result of the final (root) rmdir call, which only failed indirectly (i.e. if byproducts were left around)
  • Logging

Note that the old behavior remains the same in terms not aborting if any individual item generates an error. The main difference is that now we explicitly return false to indicate the rmdir() operation may not have truly been 100% successful.

P.S. My opinion is that rmdir() at the storage level should immediately fail rather than continue, but that's a bigger change that should be unified across the storage implementations.

P.P.S. Rate limiting logging would be nice in this area of code...

TODO

  • ...

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants