fix(comments): adjust Activity integration for changed Node API

[susnux]

Summary

The activity app integration was changed to use the files Node API instead of the legacy FileInfo API. So the comments app needs to be adjusted for it.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[szaimen]

🐘

[edward-ly]

The app works fine until I enable the activity app, at which point, the comments tab is replaced with the activity tab for me with no entries underneath. In the browser log, I get several of these errors:

[ERROR] activity: Error loading additional activity entries 
Object { app: "activity", uid: "admin", level: 0, error: TypeError }
​
app: "activity"
​
error: TypeError: can't access property "id", t is undefined
​​
columnNumber: 57784
​​
fileName: "http://nextcloud.local/dist/comments-comments-tab.js"
​​
lineNumber: 1
​​
message: `can't access property "id", t is undefined`
​​
stack: "93226/</<@http://nextcloud.local/dist/comments-comments-tab.js:1:57784\nd@http://nextcloud.local/apps-extra/activity/js/api-mFrM-9qG.chunk.mjs:1:897\ngetActivities@http://nextcloud.local/apps-extra/activity/js/ActivityTab-6Gq3gTQ6.chunk.mjs:2:1683\nasync*update@http://nextcloud.local/apps-extra/activity/js/ActivityTab-6Gq3gTQ6.chunk.mjs:2:1546\nmounted@http://nextcloud.local/apps-extra/activity/js/ActivityTab-6Gq3gTQ6.chunk.mjs:2:1405\nLt/</<@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:34178\nBn@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:20147\nht@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:20219\nNr/t.__weh@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:34059\nNs@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:21725\nIt@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:58144\nmount@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:42329\nVi/t.mount@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:83343\n_mount@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:78337\nt@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:78034\n_resolveDef/this._pendingResolve<@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:78145\npromise callback*_resolveDef@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:78098\nconnectedCallback@http://nextcloud.local/apps-extra/activity/js/index-6AAKmhoX.chunk.mjs:1:76840\ninsertBefore@http://nextcloud.local/dist/core-common.js:1:6544125\nm@http://nextcloud.local/dist/core-common.js:1:6557696\nh@http://nextcloud.local/dist/core-common.js:1:6557349\n85471/E/<@http://nextcloud.local/dist/core-common.js:1:6560061\nE@http://nextcloud.local/dist/core-common.js:1:6560245\n85471/ki@http://nextcloud.local/dist/core-common.js:1:6561381\n85471/e.prototype._update@http://nextcloud.local/dist/core-common.js:1:6537292\na@http://nextcloud.local/dist/core-common.js:1:6568785\n85471/e.prototype.get@http://nextcloud.local/dist/core-common.js:1:6519430\n85471/e.prototype.run@http://nextcloud.local/dist/core-common.js:1:6520163\nna@http://nextcloud.local/dist/core-common.js:1:6522136\n85471/bn/<@http://nextcloud.local/dist/core-common.js:1:6516936\nfn@http://nextcloud.local/dist/core-common.js:1:6516337\npromise callback*cn@http://nextcloud.local/dist/core-common.js:1:6516427\nbn@http://nextcloud.local/dist/core-common.js:1:6516998\n85471/e.prototype.$nextTick@http://nextcloud.local/dist/core-common.js:1:6538013\nrender@http://nextcloud.local/dist/core-common.js:1:4664190\n85471/e.prototype._render@http://nextcloud.local/dist/core-common.js:1:6538293\na@http://nextcloud.local/dist/core-common.js:1:6568795\n85471/e.prototype.get@http://nextcloud.local/dist/core-common.js:1:6519430\n85471/e.prototype.run@http://nextcloud.local/dist/core-common.js:1:6520163\nna@http://nextcloud.local/dist/core-common.js:1:6522136\n85471/bn/<@http://nextcloud.local/dist/core-common.js:1:6516936\nfn@http://nextcloud.local/dist/core-common.js:1:6516337\n"
​​
<prototype>: TypeError.prototype { stack: "", … }
​
level: 0
​
uid: "admin"
​
<prototype>: Object { … }
index.mjs:47:17

I'm on the latest commits for the server and all apps.

[susnux]

the comments tab is replaced with the activity tab for me with no entries underneath

exactly that should be fixed with this PR.

Did you test with

• this PR (and compile the assets)
• activity on master (at least nextcloud/activity@8b55ce7 )

[edward-ly]

Did you test with

• this PR (and compile the assets)

• activity on master (at least nextcloud/activity@8b55ce7 )

Activity is on master, but I forgot to recompile the assets. That did fix the error, thanks. Now I just get this warning (one for each comment on a file whenever the sidebar is open); is this something to worry about or no?

[WARN] activity: Activity is not an instance of ActivityModel 
Object { app: "activity", uid: "admin", level: 0, activity: Proxy }
​
activity: Proxy { <target>: {…}, <handler>: {…} }
​​
<target>: Object { _CommentsViewInstance: {…}, timestamp: 1767801964000, mount: mount(n), … }
​​
<handler>: Object { _isReadonly: false, _isShallow: false }
​
app: "activity"
​
level: 0
​
uid: "admin"
​
<prototype>: Object { … }
index.mjs:44:17

[susnux]

Now I just get this warning (one for each comment on a file whenever the sidebar is open); is this something to worry about or no?

I think its fine to ignore this for now

[edward-ly]

👍