Skip to content

Conversation

@hweihwang
Copy link
Contributor

@hweihwang hweihwang commented Jan 6, 2026

Summary

  • insert files_trash row before payload move and remove it (and payload/cache) on move failure
  • update trash cache for uncached sources using size delta to avoid full folder scan
  • delete files_trash row after payload delete
  • add regression test for uncached delete

Testing

  • not run (phpunit bootstrap requires installed instance)

Fixes #56493

@hweihwang hweihwang requested a review from a team as a code owner January 6, 2026 10:33
@hweihwang hweihwang requested review from Altahrim, leftybournes, salmart-dev and yemkareems and removed request for a team January 6, 2026 10:33
@hweihwang hweihwang marked this pull request as draft January 6, 2026 10:34
@hweihwang hweihwang marked this pull request as ready for review January 6, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trashbin copy leaves blob in /files_trashbin without oc_files_trash / filecache rows when request aborts after moveFromStorage

2 participants