refactor(psalm): Enable psalm for comments unit tests #57367
Merged
+218
−333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
ArtificialOwl,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
CarlSchwan
force-pushed
the
work/carl/psalm-unittests
branch
2 times, most recently
from
ed874cc to
9f5d0ad
Compare
artonge
approved these changes
Jan 6, 2026
artonge
reviewed
Jan 6, 2026
Member
Please note that this is not an option atm as it breaks Talk clients, federation and web interface. |
come-nc
reviewed
Jan 6, 2026
CarlSchwan
force-pushed
the
work/carl/psalm-unittests
branch
from
9f5d0ad to
e53f0fd
Compare
Altahrim
approved these changes
Jan 7, 2026
Open
CarlSchwan
force-pushed
the
work/carl/psalm-unittests
branch
from
e53f0fd to
83f264a
Compare
added 3 commits
January 7, 2026 13:21
This is the first step to enable psalm for our test suite to find issues also there. At the moment, this already found some completely broken and unused method in TestCase and prepare the way for making ICommentsManager work with snowflake ids by using string instead of int for the ids consistently. Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
work/carl/psalm-unittests
branch
from
83f264a to
6eb1609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first step to enable psalm for our test suite to find issues also there.
At the moment, this already found some completely broken and unused method in TestCase and prepare the way for making ICommentsManager work with snowflake ids by using string instead of int for the ids consistently.
Checklist
3. to review, feature component)stable32)