Skip to content

fix: allow renaming files with just update permissions #57374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
icewind1991 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: allow renaming files with just update permissions #57374

icewind1991 wants to merge 3 commits into from
+57 −18

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jan 6, 2026 •
edited
Loading

Only moving to another folder needs the delete+create permissions, for moving in the same folder just update is enough.

TODO:

  • Update files webui permissions check

@icewind1991 icewind1991 added the 2. developing Work in progress label Jan 6, 2026
@icewind1991
Copy link
Member Author

icewind1991 commented Jan 6, 2026

/compile

@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 6, 2026
@icewind1991 icewind1991 added this to the Nextcloud 33 milestone Jan 6, 2026
@icewind1991 icewind1991 marked this pull request as ready for review January 6, 2026 16:37
@icewind1991 icewind1991 requested review from a team and skjnldsv as code owners January 6, 2026 16:37
@icewind1991 icewind1991 requested review from Altahrim, ArtificialOwl, leftybournes, provokateurin, susnux and szaimen and removed request for a team January 6, 2026 16:37
@nextcloud-command
chore(assets): Recompile assets
0f7b6d9 
Signed-off-by: nextcloud-command <[email protected]>
szaimen
szaimen approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nextcloud-bot nextcloud-bot mentioned this pull request Jan 7, 2026
Open
@icewind1991
Copy link
Member Author

icewind1991 commented Jan 7, 2026

(I'll rebase etc once reviewed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@susnux susnux Awaiting requested review from susnux susnux is a code owner automatically assigned from nextcloud/server-frontend

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @szaimen @nextcloud-command