feat: add event for apps that a users share access might have changed #57392
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
leftybournes,
provokateurin,
salmart-dev and
yemkareems
and removed request for
a team
icewind1991
force-pushed
the
user-share-access-event
branch
from
7531078 to
c2a177d
Compare
Open
1 task
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
user-share-access-event
branch
from
c2a177d to
5346323
Compare
1 task
Member
Author
|
Kerberos failures are unrelated (nextcloud/user_saml#1030) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for places like #57295 where files_sharing needs to be able to react to users gaining/losing access to shares.
This would need to be implemented in at least talk and circles, not sure about deck.
Since determining this reliably will be expensive, apps are expected to emit the event optimistically, so, for example, talk should probably just emit the event whenever a user is added to a room, regardless of whether or not the room has any associated shares.
cc @nickvergessen @juliusknorr @ArtificialOwl for the relevant apps.