Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Handle last-edit displayname and deleted users #11404

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
grafik Bildschirmfoto vom 2024-01-18 16-30-34
grafik Bildschirmfoto vom 2024-01-18 16-30-22

🛠️ API Checklist

🚧 Tasks

  • Populate display name for last edits
  • Handle deleted users
  • Write test for deleted user
  • Write test for display name
  • Document empty display name on actor type deleted_users

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Jan 18, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Jan 18, 2024
@nickvergessen nickvergessen self-assigned this Jan 18, 2024
@nickvergessen nickvergessen force-pushed the bugfix/11401/last-edit-displayname branch from 53f6e4e to f5fe5dc Compare January 18, 2024 16:05
@Antreesy Antreesy self-requested a review January 19, 2024 08:03
@nickvergessen nickvergessen merged commit cb55314 into main Jan 19, 2024
54 checks passed
@nickvergessen nickvergessen deleted the bugfix/11401/last-edit-displayname branch January 19, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lastEdit... parameters haven't changed for deleted user
2 participants