Skip to content

fix(MessagesSystemGroup): collapse actor removed messages, collapse previously open groups with unread marker#11876

Merged
Antreesy merged 3 commits into
mainfrom
fix/11484/system-message-grouping
Mar 25, 2024
Merged

fix(MessagesSystemGroup): collapse actor removed messages, collapse previously open groups with unread marker#11876
Antreesy merged 3 commits into
mainfrom
fix/11484/system-message-grouping

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy commented Mar 20, 2024

☑️ Resolves

  • Ref Collapsed messages | minor bugs #11484
    • message group should be collapsed, as soon as unread marker is moved from it
    • only manually open groups will be opened after list re-render, rest will follow the rules

Rest

  • group messages ilke Administrator removed A, B and 3 other participants (copy-paster from 'user-added')
  • cycle through only existing group keys when soft updating
    • we could remove group just before in previous cycle

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Before After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added this to the 💞 Next Beta (29) milestone Mar 20, 2024
@Antreesy Antreesy requested a review from DorraJaouad March 20, 2024 13:54
@Antreesy Antreesy self-assigned this Mar 20, 2024
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…pdating

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…ad messages

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/11484/system-message-grouping branch from ccc48df to 1f82203 Compare March 21, 2024 11:36
@Antreesy Antreesy changed the title fix(MessagesSystemGroup): filter out duplicate messages from prepared group before render fix(MessagesSystemGroup): collapse actor removed messages, collapse previously open groups with unread marker Mar 21, 2024
Copy link
Copy Markdown
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test unread marker position but logic looks good 🦅.

Tested the rest ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants