feat(UX): Show a warning when bruteforce protection is throttling#11927
Merged
nickvergessen merged 1 commit intoMar 26, 2024
Conversation
nickvergessen
added
3. to review
feature: chat 💬
Antreesy
approved these changes
Mar 25, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Looks ok
Can we include request ID or user IP for backtracking?
DorraJaouad
approved these changes
Mar 25, 2024
Member
Author
|
Well that will be any "join" of a conversation. But yeah might make sense to add some info the sysadmin can find locally |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/show-warning-when-bfp-more-than-5s
branch
from
1896959 to
6fd87cb
Compare
nickvergessen
deleted the
bugfix/noid/show-warning-when-bfp-more-than-5s
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
For testing add:
Before
https://github.com/nextcloud/server/blob/25309bcb45232bf30fe719bac1776f0136f7cd7a/lib/private/AppFramework/Middleware/Security/BruteForceMiddleware.php#L136
🏁 Checklist
docs/has been updated or is not required