Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add selector for Audio Output 🔈 #12667

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add selector for Audio Output 🔈 #12667

wants to merge 4 commits into from
+210 −20

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 10, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Media selector for output
  • Device preferences handling
  • Store handling
  • Mixer usage
    • Safari warning (not supported) or hide the element
  • CallParticipants* proper update on change
  • Switch to default sinkId
    • should be ' ', but need to test how browser behaves with passing this value
    • replace None with Default in NcSelect

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari ⚠️ not supported
    • Talk Desktop
    • Not risky to browser differences / client ⚠️
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy self-assigned this Jul 10, 2024
@Antreesy

This comment was marked as off-topic.

Sign in to view
@Crashdummyy

This comment was marked as off-topic.

Sign in to view
@Antreesy

This comment was marked as off-topic.

Sign in to view
@Crashdummyy

This comment was marked as off-topic.

Sign in to view
@Antreesy

This comment was marked as off-topic.

Sign in to view
@Crashdummyy

This comment was marked as off-topic.

Sign in to view
@Antreesy

This comment was marked as off-topic.

Sign in to view
@Crashdummyy

This comment was marked as off-topic.

Sign in to view
@nickvergessen nickvergessen added this to the 🌿 Next Beta (31) milestone Jan 21, 2025
@Antreesy Antreesy force-pushed the fix/noid/audio-output branch from 8cf2274 to f8ee975 Compare February 18, 2025 10:19
@Antreesy Antreesy changed the title test: add selector for audiooutput, allow to test different speakers feat: add selector for Audio Output 🔈 Feb 18, 2025
@Antreesy Antreesy force-pushed the fix/noid/audio-output branch 2 times, most recently from b8ffe7b to 4a4efc9 Compare March 3, 2025 18:04
@Antreesy Antreesy marked this pull request as ready for review March 3, 2025 18:06
@Antreesy Antreesy requested review from ShGKme and DorraJaouad March 3, 2025 18:06
@Antreesy Antreesy force-pushed the fix/noid/audio-output branch from 4a4efc9 to a62bd3b Compare March 3, 2025 18:12
@DorraJaouad DorraJaouad added the feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients label Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@ShGKme ShGKme Awaiting requested review from ShGKme

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
2. developing enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients
Projects
💬 Talk team
Status: 🏗️ In progress
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @Crashdummyy @nickvergessen @DorraJaouad