-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openapi): Add more type/int limitations #12783
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement, everything should be documented as strictly as possible.
It's not even a breaking change, since the API is the same and only the documentation for it has changed. To the end user this is not a problem, except for the case where they generate code from it, but then they have to deal with it themselves and it doesn't concern these changes.
Also adding extra type aliases is helpful, otherwise code generators will need to come up with names and they can be ugly (and ofc then they are re-usable which also helps a lot). |
Okay thanks, then I will check if there are more things to adjust and then start fixing false-negative psalm complaints |
The psalm complaints might be legit though |
No, we just don't have get*() declare that they return the consts… |
e9dde97
to
266b68b
Compare
Pushed the current state, but spreed/lib/Model/BotServer.php Lines 15 to 18 in 1ccbf67
non-empty-string and therefore psalm afterwards complains. Similar problem with all int fields
|
266b68b
to
29fa726
Compare
* participantType: TalkParticipantTypes, | ||
* permissions: TalkPermissions, | ||
* readOnly: 0|1, | ||
* recordingConsent: 0|1|2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* recordingConsent: 0|1|2, | |
* recordingConsent: 0|1, |
Signed-off-by: Joas Schilling <[email protected]>
29fa726
to
24a26e7
Compare
Signed-off-by: Joas Schilling <[email protected]>
24a26e7
to
4c119d7
Compare
Is a break like this okay?