feat(conversations): add backend support of compact list #13994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
enhancement
feature: settings ⚙️
Antreesy
force-pushed
the
feat/11697/compact-list-api
branch
from
c335ce4 to
54c7c21
Compare
nickvergessen
requested changes
Dec 16, 2024
Antreesy
force-pushed
the
feat/11697/compact-list-api
branch
from
54c7c21 to
cd1caae
Compare
DorraJaouad
force-pushed
the
feat/11697/compact-list-api
branch
from
cd1caae to
5d0b9f8
Compare
|
Rebase onto main |
|
This is not compact enough. The entries should be as compact as the left sidebar of the settings page. So roughly 34px height and 3px spacing between. |
Antreesy
commented
Jan 10, 2025
src/components/LeftSidebar/ConversationsList/ConversationsListVirtual.vue
Outdated
Show resolved
Hide resolved
DorraJaouad
force-pushed
the
feat/11697/compact-list-api
branch
from
3e4057c to
015902a
Compare
|
Relocated Frontend changes to another PR |
nickvergessen
approved these changes
Jan 10, 2025
- int<0,1> was chosen if we further want to extend with other appearance types Signed-off-by: Joas Schilling <[email protected]> Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: DorraJaouad <[email protected]> Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
feat/11697/compact-list-api
branch
from
015902a to
3f35371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏡 After
🚧 Tasks
🏁 Checklist
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required