Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user contacts menu instead of conversation participants (there c… #14143

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix: user contacts menu instead of conversation participants (there c… #14143

merged 2 commits into from
Jan 30, 2025

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jan 16, 2025 •
edited
Loading

☑️ Resolves

  • Missing items navigation
  • Correct list of contacts rather conversation participants (some users might have left and they have messages)
  • Trigger re-fetch after removing filter chips
  • Types syntax

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Recording.2025-01-16.200647.mp4

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required
    …ould be users who left)

@DorraJaouad DorraJaouad added this to the 🌿 Next Beta (31) milestone Jan 16, 2025
@DorraJaouad DorraJaouad requested a review from Antreesy January 16, 2025 19:15
@DorraJaouad DorraJaouad self-assigned this Jan 16, 2025
@DorraJaouad DorraJaouad force-pushed the fix/search-messages-follow-up branch from b3fc49b to 42b365b Compare January 27, 2025 15:13
@DorraJaouad DorraJaouad force-pushed the fix/search-messages-follow-up branch from 42b365b to 7a51d5f Compare January 30, 2025 08:17
Antreesy
Antreesy approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest is good

src/components/RightSidebar/SearchMessages/SearchMessagesTab.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the fix/search-messages-follow-up branch from 7a51d5f to c24033f Compare January 30, 2025 09:28
@DorraJaouad DorraJaouad enabled auto-merge January 30, 2025 09:29
@DorraJaouad
Copy link
Contributor Author

/backport to stable31

@DorraJaouad DorraJaouad merged commit e3b852b into main Jan 30, 2025
53 checks passed
@DorraJaouad DorraJaouad deleted the fix/search-messages-follow-up branch January 30, 2025 09:31
@backportbot backportbot bot mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
3 participants
@DorraJaouad @nickvergessen @Antreesy