Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inverse left arrow icons when it is RTL #14144

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: inverse left arrow icons when it is RTL #14144

wants to merge 4 commits into from
+26 −21

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jan 16, 2025 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • If there is a left arrow icon that shouldn't be reversed
  • Off topic change was the back button in poll editor because it was overlapping the close button

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🌿 Next Beta (31) milestone Jan 16, 2025
@DorraJaouad DorraJaouad requested a review from Antreesy January 16, 2025 19:20
@DorraJaouad DorraJaouad self-assigned this Jan 16, 2025
ShGKme
ShGKme reviewed Jan 16, 2025
View reviewed changes
src/App.vue Outdated Show resolved Hide resolved
@DorraJaouad
fix: inverse icons when it is RTL
701ddee 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: left arrow icons
d822928 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: right arrow icons
d6d2798 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad DorraJaouad force-pushed the fix/noid/rtl-support-search-messages branch from 060fcec to f4319cc Compare January 17, 2025 15:18
@DorraJaouad
fix: miscellaneous changes
e06900c 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad DorraJaouad force-pushed the fix/noid/rtl-support-search-messages branch from f4319cc to e06900c Compare January 18, 2025 18:16
@DorraJaouad DorraJaouad changed the title fix(App): inverse left arrow icons when it is RTL fix: inverse left arrow icons when it is RTL Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme left review comments

@nickvergessen nickvergessen nickvergessen left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
🌿 Next Beta (31)
Development

Successfully merging this pull request may close these issues.
4 participants
@DorraJaouad @nickvergessen @ShGKme @Antreesy