Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conversation): Only trigger event with users that really got removed #14394

Merged

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 14, 2025

☑️ Resolves

🛠️ API Checklist

42 is my moderator user that triggered the action:

Before:

No longer invited to 66vfwn2f: Array                                                                            │
│(                                                                                                                                                                            │
│    [0] => 02d68bf5-3e5c-4bac-bd45-6f1925279d29                                                                                                                              │
│    [1] => 42                                                                                                                                                                │
│    [2] => 649a454f-4ea9-4332-8c5e-4aceda302c60                                                                                                                              │
│    [3] => 846b1496-4732-4ce6-aacc-fc0a06a34429                                                                                                                              │
│    [4] => be7fb6dd 702e 4913 af5d c48718bfc8c9                                                                                                                              │
│    [5] => ce0d5740-7aaf-4332-a267-6bbfae2603c0                                                                                                                              │
│    [6] => fb03192a-639a-4735-8a58-1a3108751a94                                                                                                                              │
│)                                                       

After:

spreed-hpb   No longer invited to 66vfwn2f: Array                                                                            │
│(                                                                                                                                                                            │
│    [0] => 02d68bf5-3e5c-4bac-bd45-6f1925279d29                                                                                                                              │
│    [1] => 649a454f-4ea9-4332-8c5e-4aceda302c60                                                                                                                              │
│    [2] => 846b1496-4732-4ce6-aacc-fc0a06a34429                                                                                                                              │
│    [3] => be7fb6dd 702e 4913 af5d c48718bfc8c9                                                                                                                              │
│    [4] => ce0d5740-7aaf-4332-a267-6bbfae2603c0                                                                                                                              │
│    [5] => fb03192a-639a-4735-8a58-1a3108751a94                                                                                                                              │
│)                                                   

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: signaling 📶 Internal and external signaling backends feature: conversations 👥 labels Feb 14, 2025
@nickvergessen nickvergessen added this to the 🪺 Next Major (32) milestone Feb 14, 2025
@nickvergessen nickvergessen self-assigned this Feb 14, 2025
@nickvergessen
Copy link
Member Author

/backport to stable31

@nickvergessen
Copy link
Member Author

/backport to stable30

@nickvergessen
Copy link
Member Author

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 feature: signaling 📶 Internal and external signaling backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Participants from a team/group, promoted to moderators, are kicked out if team/group is removed
2 participants