Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conversations): remove Delete conversation from quick actions conversation menu #14445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 18, 2025

☑️ Resolves

  • There is a "Delete conversation" in the conversation list quick actions menu
  • Unlike leaving, it is a very destructive operation
  • IMO, it shouldn't be available in a conversation menu
  • Even with the confirmation dialog, a user may just quickly click "Confirm" without reading
    • There is a similar dialog on leaving which is not so dangerous
  • To reduce the risk of accidental deletion, I'd propose removing it from the close menu
  • A user can still remove conversation from the settings, where it is more obviously a destructive operation

Alternative - having double confirmation.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@nickvergessen
Copy link
Member

nickvergessen commented Feb 18, 2025

Alternative - having double confirmation.

We had some thoughts about that in another call. It e.g. would make sense to ask for further confirmation if the conversation is:

  • Having many chats (ours had 25k)
  • Having many shares (ours had 1.3k)
  • Is Old but still Current (first message from 2019, latest from 2025)

Instead of removing it, we could open the "Danger zone" area when click on Delete?

@nimishavijay
Copy link
Member

Instead of removing it, we could open the "Danger zone" area when click on Delete?

Works for me, also makes it different from the "leave conversation" confirmation.

@Antreesy
Copy link
Contributor

Something like this should work then:

Conversation.vue:

emit('show-conversation-settings', { token: this.item.token, sectionId: 'dangerzone' })

ConversationSettingsDialog.vue:

handleShowSettings({ token, sectionId }) {
	...
	if (sectionId) {
		this.$nextTick(() => {
			document.getElementById(`settings-section_${sectionId}`).scrollIntoView()
		})
	}
}

@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 25, 2025

Something like this should work then

It should move the focus first, otherwise the user is moved back on keyboard navigation

document.getElementById(settings-section_${sectionId})

It is not a public API, can be broken on minor update

@Antreesy
Copy link
Contributor

can be broken on minor update

I just meant the approach. We can scroll to the Talk-defined header we know will exist in this place: DangerZone -> <h4>Delete conversation</h4>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants