Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(conversation): Add new API endpoint that allows to provide all s… #14497

Merged
merged 5 commits into from
Mar 6, 2025
Merged

feat(conversation): Add new API endpoint that allows to provide all s… #14497

merged 5 commits into from
Mar 6, 2025

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 25, 2025 •
edited
Loading

…ettings

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Add all options
  • Add participant inviting
  • Expose failed invitations
  • Add breakout room special handling from old createEmptyRoom()

⚕️ Followup

  • Allow uploading avatar?
  • Migrate addParticipantToRoom to InvitationList
  • Migrate OCC to InvitationList

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the 🪺 Next Major (32) milestone Feb 25, 2025
@nickvergessen nickvergessen self-assigned this Feb 25, 2025
@nickvergessen nickvergessen force-pushed the feat/14400/add-participant-to-one-to-one-api branch 2 times, most recently from fd51478 to c49bccb Compare March 3, 2025 16:29
miaulalala
miaulalala reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions

@nickvergessen nickvergessen force-pushed the feat/14400/add-participant-to-one-to-one-api branch from c49bccb to 5fdde80 Compare March 4, 2025 15:44
miaulalala
miaulalala requested changes Mar 6, 2025
View reviewed changes
@nickvergessen nickvergessen requested a review from miaulalala March 6, 2025 11:29
@miaulalala miaulalala merged commit c488752 into main Mar 6, 2025
79 checks passed
@miaulalala miaulalala deleted the feat/14400/add-participant-to-one-to-one-api branch March 6, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥
Projects
💬 Talk team
Status: ☑️ Done
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.

👥 Adding participants to one-to-one calls - ⚙️ API
2 participants
@nickvergessen @miaulalala