fix: migrate fileSharingServices to TS #14586
Open
+179
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
DorraJaouad
reviewed
Mar 9, 2025
| * @param payload The function payload | ||
| * @param payload.path The file path from the user's root directory | ||
| * @param payload.shareWith The conversation's token | ||
| * @param payload.referenceId An optional reference id to recognize the message later |
There was a problem hiding this comment.
Suggested change
| * @param payload.referenceId An optional reference id to recognize the message later | |
| * @param payload.referenceId A reference id to recognize the message later |
Everything is optional here
Comment on lines
+210
to
+222
| try { | ||
| await shareFile({ path: filePath, shareWith: this.token }) | ||
| } catch (error) { | ||
| console.error('Error while sharing file: ', error) | ||
| if (error?.response?.status === 403) { | ||
| showError(t('spreed', 'You are not allowed to share files')) | ||
| } else if (error?.response?.data?.ocs?.meta?.message) { | ||
| showError(error.response.data.ocs.meta.message) | ||
| this.newFileError = error.response.data.ocs.meta.message | ||
| } else { | ||
| showError(t('spreed', 'Error while sharing file')) | ||
| } | ||
| } |
There was a problem hiding this comment.
This looks like a good store action (redundant 3 times now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🏁 Checklist