Skip to content

fix: improve string handling#14650

Merged
DorraJaouad merged 4 commits intomainfrom
fix/string-processing
Apr 1, 2025
Merged

fix: improve string handling#14650
DorraJaouad merged 4 commits intomainfrom
fix/string-processing

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 14, 2025 •
edited
Loading

☑️ Resolves

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad requested a review from Antreesy March 14, 2025 19:06
@DorraJaouad DorraJaouad self-assigned this Mar 14, 2025
@DorraJaouad DorraJaouad added this to the 🪺 Next Major (32) milestone Mar 14, 2025
nickvergessen
nickvergessen reviewed Mar 18, 2025
View reviewed changes
nickvergessen
nickvergessen reviewed Mar 18, 2025
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the fix/string-processing branch 2 times, most recently from b83a58c to d27683a Compare March 20, 2025 14:39
Antreesy
Antreesy approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a skipped console debug, otherwise good

@DorraJaouad
fix(deps): npm install entities
e455351 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix(textParse): change the parsing workaround
d1c3dd5 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix(readableNumber): omit using variables in regex
d68abc9 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix(strings): use Constant Format String
5583d17 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/string-processing branch from d27683a to 5583d17 Compare April 1, 2025 07:14
@DorraJaouad DorraJaouad merged commit 1d8c8bc into main Apr 1, 2025
54 checks passed
@DorraJaouad DorraJaouad deleted the fix/string-processing branch April 1, 2025 07:36
@DorraJaouad
Copy link
Contributor Author

DorraJaouad commented Apr 1, 2025

/backport to stable31

@backportbot backportbot bot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels

feature: frontend 🖌️ "Web UI" client technical debt

Projects

None yet

Milestone

v22.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@DorraJaouad @nickvergessen @Antreesy