fix: improve string handling #14650
Open
fix: improve string handling #14650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorraJaouad
force-pushed
the
fix/string-processing
branch
from
5ce7d34 to
b83a58c
Compare
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
DorraJaouad
force-pushed
the
fix/string-processing
branch
from
b83a58c to
d27683a
Compare
Antreesy
approved these changes
Mar 20, 2025
Comment on lines
102
to
+104
| console.debug('Changed quality to ' + quality) | ||
| } catch (error) { | ||
| console.warn('Failed to set quality ' + quality, error) | ||
| console.warn('Failed to set quality %s', quality, error) |
There was a problem hiding this comment.
it could be a digit, as I judge from the code and console output.
Also debug should be changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist