Skip to content

feat: reduce items rendering in left sidebar search results #14669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 27, 2025
Merged

feat: reduce items rendering in left sidebar search results #14669

merged 9 commits into from
Mar 27, 2025

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 17, 2025 •
edited
Loading

☑️ Resolves

Rendering went from n items rendered out of n (100%) to 15-30 items out of n items.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After

🚧 Tasks

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad force-pushed the fix/left-sidebar-search branch 4 times, most recently from 822e53b to 21a55e2 Compare March 20, 2025 15:57
@DorraJaouad DorraJaouad changed the title feat: implement recycle scroller to left sidebar search results feat: reduce items rendering in left sidebar search results Mar 20, 2025
@DorraJaouad DorraJaouad self-assigned this Mar 20, 2025
@DorraJaouad DorraJaouad moved this to 🏗️ In progress in 💬 Talk team Mar 20, 2025
@DorraJaouad DorraJaouad requested review from Antreesy and ShGKme March 20, 2025 16:09
@DorraJaouad DorraJaouad added this to the 🪺 Next Major (32) milestone Mar 20, 2025
@DorraJaouad DorraJaouad marked this pull request as ready for review March 20, 2025 16:09
@DorraJaouad DorraJaouad force-pushed the fix/left-sidebar-search branch 2 times, most recently from 8818ae1 to e3a876f Compare March 21, 2025 11:18
Antreesy
Antreesy reviewed Mar 24, 2025
View reviewed changes
ShGKme
ShGKme reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stylistic comments

@DorraJaouad DorraJaouad force-pushed the fix/left-sidebar-search branch 2 times, most recently from 6335fec to 486b0de Compare March 26, 2025 15:57
@ShGKme
Copy link
Contributor

ShGKme commented Mar 26, 2025 •
edited
Loading

A force-push after review in large PRs requires to review everything again from the start 😢

ShGKme
ShGKme reviewed Mar 26, 2025
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the fix/left-sidebar-search branch from 486b0de to fd11ca4 Compare March 27, 2025 16:24
ShGKme
ShGKme reviewed Mar 27, 2025
View reviewed changes
Antreesy
Antreesy reviewed Mar 27, 2025
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the fix/left-sidebar-search branch from 40b4ba9 to 8c2d107 Compare March 27, 2025 20:20
Antreesy
Antreesy approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DorraJaouad
feat: implement recycle scroller to left sidebar search results
8a696c0 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: move search output logic to a new component
f47dbf9 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: make search results processing more centralized in SearchConvers…
aadb5fb 
…ationsResults. Refactor flat list creation

Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: enable compact style for search results
f767063 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: align spaces between all sections in normal mode
82aeec8 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix(ts): add types
7f66339 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: reduce props where component does not actually rely on parent. R…
f31ccac 
…efactor virtual list in order to reduce loops.

Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: restore list clicking behavior when showing search results
ed6f092 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: adjust jest. Remove the part of clicking testing because the rec…
3d1e1c3 
…ycle scroller is stubbed on the wrapper level and can no longer trigger clicking.

Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad DorraJaouad force-pushed the fix/left-sidebar-search branch from 8c2d107 to 3d1e1c3 Compare March 27, 2025 20:44
@DorraJaouad DorraJaouad merged commit b2e2d5e into main Mar 27, 2025
53 checks passed
@DorraJaouad DorraJaouad deleted the fix/left-sidebar-search branch March 27, 2025 22:26
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💬 Talk team Mar 27, 2025
@DorraJaouad
Copy link
Contributor Author

/backport to stable31

@backportbot backportbot bot mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: conversations 👥 feature: frontend 🖌️ "Web UI" client technical debt
Projects
💬 Talk team
Status: ☑️ Done
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.

🔍 Fix infinite scrolling issue in left sidebar when searching with 1k conversations
3 participants
@DorraJaouad @ShGKme @Antreesy