refactor(room): Split two-arg setActiveSince() into single-arg setters

[miaulalala]

Part of the incremental migration of Room to extend OCP\AppFramework\Db\Entity (Phase 1d).

Room::setActiveSince(\DateTime $since, int $callFlag) combined two concerns — conditionally setting the active-since timestamp and bitwise-ORing the call flag — in a single two-argument method. Entity's magic __call() requires standard single-argument setters.

• Replace with setActiveSince(?\DateTime $activeSince) and setCallFlag(int $callFlag)
• Move the conditional/bitwise logic into RoomService::setActiveSince(), where it already lived conceptually

Why the split is safe

cc @nickvergessen

This differs from the related getLobbyState()/getLobbyTimer() refactor in an important way: there is no interdependency problem here.

The original setter's logic was already redundant:

• The if (!$this->activeSince) guard in Room was defensive duplication — RoomService already ensures setActiveSince() is only called on the fresh-call path (when getActiveSince() === null), never on the upgrade-flags path.
• The $this->callFlag |= $callFlag bitwise merge was also redundant — RoomService::setActiveSince() already computes $callFlag |= $oldCallFlag before calling Room's setter.

Events fire after both setters: On the fresh-call path, CallStartedEvent is dispatched after both room->setActiveSince() and room->setCallFlag(). No event handler observes state between the two calls. Same for the upgrade-flags path.

Getters were already pure: getActiveSince() and getCallFlag() never had side effects. The lobby refactor exposed a problem with lazy side effects in getters; that pattern does not exist here.

AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com

🛠️ API Checklist

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not possible
• 📘 API documentation in docs/ has been updated or is not required
• 🔖 Capability is added or not needed

[miaulalala]

@copilot resolve the conflicts

[Copilot]

@copilot resolve the conflicts

Resolved in d67c7a2. Merged origin/main and fixed the conflict in tests/php/RoomTest.php by combining main's lobby-purity tests with this branch's setActiveSince/setCallFlag tests, and updating createRoom() to match main's updated signature (dropped ITimeFactory, added $lobbyTimer/$lobbyState params).