Skip to content

feat: Temporarily mute conversations#17816

Draft
SystemKeeper wants to merge 3 commits intomainfrom
feat/14996/mute-conversations
Draft

feat: Temporarily mute conversations#17816
SystemKeeper wants to merge 3 commits intomainfrom
feat/14996/mute-conversations

Conversation

@SystemKeeper
Copy link
Copy Markdown
Contributor

@SystemKeeper SystemKeeper commented Apr 26, 2026

🛠️ API Checklist

🚧 Tasks

  • Discuss if we should really use non-null DateTime here as it has some (code-)overhead. Either we can use a nullable DateTime (but then we need to have an OR in the call query), or use an int for the timestamp. => Int it is.
  • Discuss if this makes sense for 24 at all. => 25 it is.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper force-pushed the feat/14996/mute-conversations branch from f38c4b9 to fd2dc3f Compare April 26, 2026 21:11
@SystemKeeper SystemKeeper added feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 enhancement labels Apr 26, 2026
@SystemKeeper SystemKeeper added this to the 🏖️ Next Major (34) milestone Apr 26, 2026
@SystemKeeper SystemKeeper marked this pull request as ready for review April 26, 2026 21:25
@SystemKeeper SystemKeeper self-assigned this Apr 26, 2026
@ShGKme
Copy link
Copy Markdown
Contributor

ShGKme commented Apr 27, 2026

Do I get it correctly that "Muted conversation" is a conversation which has notifications disabled for a specified period of time? But not the conversation that just has notifications disabled (like possible now).

@SystemKeeper
Copy link
Copy Markdown
Contributor Author

Do I get it correctly that "Muted conversation" is a conversation which has notifications disabled for a specified period of time? But not the conversation that just has notifications disabled (like possible now).

Yes. It does not alter your notification settings, so if you have a conversation with "All messages" notification set, you can still mute it for x hours for example. After the specified time, notifications work again as before.

Comment thread docs/capabilities.md Outdated
Comment thread lib/Controller/RoomController.php Outdated
Copy link
Copy Markdown
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either we can use a nullable DateTime (but then we need to have an OR in the call query), or use an int for the timestamp.

Ah now I see the problem. Since we have quite some int-timestamps on this table already, might be the easiest to got with that for now?

Comment thread lib/Controller/RoomController.php Outdated
Comment thread lib/Model/Attendee.php Outdated
Comment thread lib/Model/Attendee.php Outdated
Comment thread lib/Model/AttendeeMapper.php Outdated
Comment thread lib/Service/ParticipantService.php Outdated
Comment thread lib/Service/ParticipantService.php Outdated
Comment thread lib/Service/ParticipantService.php Outdated
Comment thread lib/ResponseDefinitions.php Outdated
Comment thread lib/Migration/Version24000Date20260419190830.php
@nickvergessen nickvergessen marked this pull request as draft April 27, 2026 12:53
@SystemKeeper SystemKeeper force-pushed the feat/14996/mute-conversations branch from 6c85f90 to 13ee37f Compare April 27, 2026 13:18
@SystemKeeper SystemKeeper force-pushed the feat/14996/mute-conversations branch from 13ee37f to 164d7db Compare April 27, 2026 13:26
@nickvergessen nickvergessen changed the title feat: Mute conversations feat: Temporarily mute conversations Apr 27, 2026
Comment thread lib/Migration/Version24000Date20260419190830.php Outdated
Comment thread lib/Model/Attendee.php Outdated
@SystemKeeper SystemKeeper force-pushed the feat/14996/mute-conversations branch from 42ad4b2 to 95d512c Compare April 27, 2026 13:47
Comment thread appinfo/info.xml
]]></description>

<version>24.0.0-dev.2</version>
<version>24.0.0-dev.3</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the note: conversation-tags were merged

Suggested change
<version>24.0.0-dev.3</version>
<version>24.0.0-dev.4</version>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants