Skip to content

feat(CallButton): add a split-menu with 'silent call' action #18913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Antreesy wants to merge 1 commit into from
Open

feat(CallButton): add a split-menu with 'silent call' action #18913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 80 additions & 3 deletions src/components/TopBar/CallButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ import { useIsMobile } from '@nextcloud/vue/composables/useIsMobile'
import { computed, ref, watch } from 'vue'
import { useRouter } from 'vue-router'
import { useStore } from 'vuex'
import NcActionButton from '@nextcloud/vue/components/NcActionButton'
import NcActions from '@nextcloud/vue/components/NcActions'
import NcButton from '@nextcloud/vue/components/NcButton'
import NcLoadingIcon from '@nextcloud/vue/components/NcLoadingIcon'
import IconChevronDown from 'vue-material-design-icons/ChevronDown.vue'
import IconPhone from 'vue-material-design-icons/Phone.vue' // Filled used for non-silent calls
import IconPhoneDialOutline from 'vue-material-design-icons/PhoneDialOutline.vue'
import IconPhoneOutline from 'vue-material-design-icons/PhoneOutline.vue'
Expand Down Expand Up @@ -95,6 +98,13 @@ const startCallButtonDisabled = computed(() => {
|| !tokenStore.currentConversationIsJoined
|| blockCalls
})
const showSplitStartCallButton = computed(() => {
return showStartCallButton.value
&& !props.isMediaSettings
&& !isPhoneRoom.value
&& !hasExternalCallService(conversation.value)
&& !hasCall.value
})
const showRecordingWarning = computed(() => {
return [
CALL.RECORDING.VIDEO_STARTING,
Expand Down Expand Up @@ -130,18 +140,23 @@ const startCallTitle = computed(() => {
return ''
})

const startCallSilentlyLabel = t('spreed', 'Start call silently')
const startCallActionsLabel = t('spreed', 'More actions')

watch(token, (newValue, oldValue) => {
callViewStore.resetCallHasJustEnded()
talkHashStore.resetTalkProxyHashDirty(oldValue)
})

/**
* Start or join the call
*
* @param silent - force a silent start, bypassing the `silentCall` prop
*/
async function handleJoinCall() {
async function handleJoinCall(silent?: boolean) {
loading.value = true
await joinCall(token.value, {
silent: hasCall.value ? true : props.silentCall,
silent: hasCall.value ? true : (silent ?? props.silentCall),
recordingConsent: props.recordingConsentGiven,
shouldStartRecording: props.isRecordingFromStart,
})
Expand Down Expand Up @@ -173,6 +188,16 @@ function handleClick() {
}
}

/**
* Skip the device checker (MediaSettings) and start the call right away
*/
function handleStartCallSilently() {
// Create audio objects as a result of a user interaction to allow playing sounds in Safari
soundsStore.initAudioObjects()

handleJoinCall(true)
}

/**
* Initiate a call at external service (iframe embedded)
*/
Expand Down Expand Up @@ -203,8 +228,40 @@ async function handleExternalCall() {
</script>

<template>
<NcActions
v-if="showSplitStartCallButton"
class="join-call join-call-actions--split"
:title="startCallTitle"
:disabled="startCallButtonDisabled || loading || isJoiningCall"
:forceName="showButtonText"
placement="top-end"
variant="primary"
:aria-label="startCallActionsLabel"
:inline="1">
<template #icon>
<IconChevronDown :size="20" />
</template>
<NcActionButton
class="start-call-button--split"
:aria-label="startCallLabel"
@click="handleClick">
<template #icon>
<NcLoadingIcon v-if="isJoiningCall || loading" :size="20" />
<IconPhone v-else :size="20" />
</template>
<template v-if="showButtonText" #default>
{{ startCallLabel }}
</template>
</NcActionButton>
<NcActionButton @click="handleStartCallSilently">
<template #icon>
<IconPhoneOutline :size="20" />
</template>
{{ startCallSilentlyLabel }}
</NcActionButton>
</NcActions>
<NcButton
v-if="showStartCallButton"
v-else-if="showStartCallButton"
:title="startCallTitle"
:aria-label="startCallLabel"
:disabled="startCallButtonDisabled || loading || isJoiningCall"
Expand Down Expand Up @@ -246,4 +303,24 @@ async function handleExternalCall() {
background-color: var(--join-call-border-color);
}
}

.join-call-actions--split {
gap: 1px !important;
}

.join-call-actions--split :deep(.action-item--single) {
border-start-end-radius: 2px;
border-end-end-radius: 2px;
}

.join-call-actions--split :deep(.action-item__menutoggle) {
--button-size: var(--clickable-area-small);
height: var(--default-clickable-area);
border-start-start-radius: 2px;
border-end-start-radius: 2px;
}

.join-call-actions--split :deep(.action-item--open .action-item__menutoggle) {
background-color: var(--color-primary-element-hover) !important;
}
</style>
Loading