Fall back when crypto.randomUUID is unavailable over HTTP - #18986
Open
xhon-pelushi wants to merge 1 commit into
Open
Fall back when crypto.randomUUID is unavailable over HTTP#18986xhon-pelushi wants to merge 1 commit into
xhon-pelushi wants to merge 1 commit into
Conversation
Draft upload temp names used crypto.randomUUID(), which throws on non-secure contexts. Use the existing uuid helper as a fallback so Talk file uploads work over HTTP as well as HTTPS. Fixes nextcloud#18733 Signed-off-by: xhon-pelushi <xhon@pelushi.com>
Antreesy
reviewed
Aug 12, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Looks fine.
Please address frontend-related CI failures, reword commit message to follow convention and disclose AI usage with 'Assisted-by' trailer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crypto.randomUUID()for temporary filenames.TypeError.crypto.randomUUIDwhen present; otherwise use the existinguuidhelper already used elsewhere in Talk.Fixes #18733
Test plan