Adjust public share page to layout changes in Nextcloud 25#7865
Merged
marcoambrosini merged 2 commits intoSep 9, 2022
Merged
Conversation
danxuliu
added
2. developing
bug
feature: frontend 🖌️
The content now has an explicit width and height set in the server style that takes into account the margins, so it does not need to be overriden. The footer, on the other hand, now has a fixed position, but as the element is moved into the #app-content when the Talk sidebar is loaded it needs to be set as relative instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The iframe of the PDF viewer is shown with an absolute position and full width and height, so it takes the size of the first parent with a relative or fixed position. That parent was the main content element, which is also a parent of the sidebar and therefore its size includes it, so the iframe filled the content and extended behind the sidebar. To solve that now a relative position is set for #app-content, which is a sibling of the sidebar and therefore prevents the iframe from overlapping it. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
adjust-public-share-page-to-layout-changes-in-nextcloud-25
branch
from
a478e97 to
a0f9c62
Compare
marcoambrosini
approved these changes
Sep 9, 2022
marcoambrosini
deleted the
adjust-public-share-page-to-layout-changes-in-nextcloud-25
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7851
Pending: