Fix visibility of sidebar toggle#7871
Merged
marcoambrosini merged 1 commit intoSep 9, 2022
Merged
Conversation
Using the new syntax for slots Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
25 tasks
danxuliu
approved these changes
Sep 9, 2022
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Tested and works 👍
From what I could see the only missing icon was the one to open the sidebar, the others were fine before this pull request. I guess they were changed too just for consistency, but I mention it just in case.
And is all that expected (that the new syntax is needed only for the icon to open the sidebar and the rest are fine with the old syntax)? Or something else needs to be fixed, for example in nextcloud-vue?
Member
Author
|
Not sure why it's needed only there, maybe because of some nested slot magic in the actionbuttons? |
marcoambrosini
deleted the
bugfix/7866/fix-visibility-of-sidebar-toggle
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the new syntax for slots
fixes #7872
Signed-off-by: Marco Ambrosini marcoambrosini@icloud.com