Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload always fails for 1MB+ #2532

Merged
merged 3 commits into from
Oct 28, 2022
Merged

File upload always fails for 1MB+ #2532

merged 3 commits into from
Oct 28, 2022

Conversation

starypatyk
Copy link
Contributor

This might fix #2519

These changes fixed the issue for me. I was inspired by this article on SO:
https://stackoverflow.com/a/65132840

Unfortunately I am not able to test it reasonably in the next few days.

@mahibi - feel free to reject this PR if you have a better solution.

@mahibi mahibi force-pushed the bugfix/2519/file_upload branch from 19be52d to 8dd6fe1 Compare October 28, 2022 14:04
@mahibi mahibi added this to the 15.0.2 milestone Oct 28, 2022
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2532-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings112112
Errors11

SpotBugs

CategoryBaseNew
Bad practice44
Correctness7575
Dodgy code315315
Experimental22
Internationalization99
Malicious code vulnerability5353
Performance2323
Security22
Total483483

@GVLLIFESTYLE
Copy link

The link does not work: Object not found!

@mahibi
Copy link
Collaborator

mahibi commented Nov 14, 2022

The link does not work: Object not found!

sry. lets try https://download.nextcloud.com/android/talk-alpha/android-talk-150010008.apk

@GVLLIFESTYLE
Copy link

in this app the sharing with files works again, thanks for the hf

@starypatyk
Copy link
Contributor Author

@mahibi - I have noticed that this PR has been added to the 15.0.2 milestone, but the changes have been only merged into master, not backported to the stable-15.0 branch.

@mahibi
Copy link
Collaborator

mahibi commented Nov 24, 2022

oh you are right 🙆‍♂️ thanks for the hint @starypatyk !!

@mahibi mahibi restored the bugfix/2519/file_upload branch November 24, 2022 08:13
@mahibi
Copy link
Collaborator

mahibi commented Nov 24, 2022

/backport to stable-15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: chat 🗨️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File upload always fails for 1MB+ version 15.0.x
4 participants