Abstracting away media player

[rapterjet2004]

• fixes Abstract away the MediaPlayer logic in ChatActivity to MediaPlayerManager #4563

🖼️ Screenshots

Example of background play
// TODO update screenshot

🚧 TODO

• Add functionality to MediaPlayerManager
• Create Background Voice Message View
• Rewrite ChatActivity to use MediaPlayerManager
  • play
  • stop
  • pause
  • seek
• Resumes playback of VoiceMessages on screen rotation
• Continue playing a voice message in background
  • Bug: Enter into the original conversation after lifecycle change. Seek Bar not updated.
  • Bug: After orientation change. Seek Bar not updated. Scope is canceled.
• Implement Voice Message card
  • play
  • close
  • pause
  • avatar
  • animation
• Auto play consecutive audio messages
  • prefetch audio messages
  • show fetched audio durations
  • temporarily mark as listened audio messages
• Get playback speed controls working
  • bug: Works, but UI doesn't update ( check cycling too )
• Test it out with Voice Recording Message Input Fragment

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4579-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	158	158
Errors	71	71

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	222	226
Dodgy code	71	71
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	310	314

SpotBugs increased!