Rework can leave/delete conversation

[mahibi]

resolve #4570

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	104	104
Errors	36	36

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	222	222
Dodgy code	71	71
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	310	310

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4627-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[mahibi]

asked in chat:

Not sure if i understand #4570 correctly.
So if i understand correctly, regarding
"If the attribute canLeaveConversation is there it should be respected no matter any other things. Same for canDeleteConversation."
there is nothing to do as this is already the case:

talk-android/app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt

Lines 858 to 868 in 35f9e33

	if (!conversation!!.canLeaveConversation) {
	binding.leaveConversationAction.visibility = GONE
	} else {
	binding.leaveConversationAction.visibility = VISIBLE
	}
	if (!conversation!!.canDeleteConversation) {
	binding.deleteConversationAction.visibility = GONE
	} else {
	binding.deleteConversationAction.visibility = VISIBLE
	}

And regarding
"Also make sure that canDeleteConversation is used to determine if "Delete all message" is shown."
i made the change
https://github.com/nextcloud/talk-android/pull/4627/files
Is that's all for the issue or did i get something wrong?

answer from Joas:

then it's good. The web accidentally had an additional condition for one-to-one conversations to hide delete