avoid shimmer animations overlay with chat messages #4629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea to show the progress bar (aka shimmer animation) was that it show not be shown at all if loading messages happens in less than a second (this was a better UX in my opinion). The idea was to hide the progress bar when ChatMessageStartState was triggered. However there can be moment when adapter is still empty after ChatMessageStartState and if in this moment the DELAY_TO_SHOW_PROGRESS_BAR is reached before the adapter is actually filled, the overlay happens. It could be a solution to move the hiding of the progress bar, however then special cases might have to be handled. For simplicity, the logic for DELAY_TO_SHOW_PROGRESS_BAR is removed. Progress bar is always shown without a delay so it wont be triggered on a later moment and can't overlay the chat. Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
bugfix/4626/avoidChatLoadingShimmerOverlay
branch
from
5e69eb1 to
20612c8
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4629-talk.apk |
rapterjet2004
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
@mahibi Noticed a bug with offline support - approving anyway for your convenience
Edit: Created a issue. Same thing #4643
- turned on airplane mode
- entered into a conversation without any offline messages saved
- Shimmer present when it shouldn't be
Also when you reenter the conversation the background icon is still there. ( TBH I like the effect, reminds me of backgrounds on Telegram and Whatsapp. Chat backgrounds a future feature?), but I don't know if it's related to your PR or mine when I implemented the feature some time ago.
|
Oops, didn't realize auto-merge was on. My bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4626
The idea to show the progress bar (aka shimmer animation) was that it show not be shown at all if loading messages happens in less than a second (this was a better UX in my opinion).
The idea was to hide the progress bar when
ChatMessageStartState was triggered.
However there can be moment when adapter is still empty after ChatMessageStartState and if in this moment the DELAY_TO_SHOW_PROGRESS_BAR is reached before the adapter is actually filled, the overlay happens. It could be a solution to move the hiding of the progress bar, however then special cases might have to be handled.
For simplicity, the logic for DELAY_TO_SHOW_PROGRESS_BAR is removed. Progress bar is always shown without a delay so it wont be triggered on a later moment and can't overlay the chat.
🏁 Checklist
/backport to stable-xx.x