Skip to content

Improve subline when last message is attachment #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve subline when last message is attachment #4940

wants to merge 3 commits into from
+58 −11

Conversation

sowjanyakch
Copy link
Contributor

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch
add icon
e6f2c88 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
theming
0285ee5 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch sowjanyakch self-assigned this Apr 30, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Apr 30, 2025
@sowjanyakch
fix detekt
86cf59d 
Signed-off-by: sowjanyakch <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings99101
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness22216
Dodgy code7167
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310100

Lint increased!

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4940-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

At least 1 approving review is required to merge this pull request.

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve subline when last message is attachment with caption
1 participant
@sowjanyakch