Skip to content

Improve AccountDialogFragment #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Improve AccountDialogFragment #5227

wants to merge 33 commits into from

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Aug 5, 2025 •
edited
Loading

fix #5095.

  • Convert Rxjava into Coroutines.
  • MVVM architecture.
  • Jetpack compose

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from 2b4abf1 to b16b4e2 Compare August 5, 2025 16:39
@sowjanyakch sowjanyakch marked this pull request as draft August 5, 2025 16:39
@sowjanyakch sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch 2 times, most recently from 5891e08 to 8410fc9 Compare August 13, 2025 10:03
@sowjanyakch sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch 2 times, most recently from 6e690c2 to 8c87187 Compare September 22, 2025 17:20
@sowjanyakch sowjanyakch marked this pull request as ready for review September 22, 2025 17:32
@sowjanyakch sowjanyakch self-assigned this Sep 22, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Sep 22, 2025
@sowjanyakch sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from 1bfc357 to 4d3ac42 Compare September 23, 2025 07:30
@sowjanyakch sowjanyakch marked this pull request as draft September 23, 2025 09:26
@sowjanyakch sowjanyakch marked this pull request as ready for review September 23, 2025 14:48
mahibi
mahibi requested changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The settings should be available when being offline. If some settings are not available offline, it should be handled inside the settings screen. But removing an account etc should be possible also without connection.

@sowjanyakch sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from efa3067 to f30b5b0 Compare October 6, 2025 15:49
@sowjanyakch
Copy link
Contributor Author

settings option is shown in the accounts dialog when the device is offline. Handling settings screen will be done in a different PR. I created a seperate issue for it #5440

@sowjanyakch sowjanyakch requested a review from mahibi October 6, 2025 15:56
@sowjanyakch
Rename .java to .kt
700efdc 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add composable dialog fragment
e5922ef 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add click listeners - add account
baa5c4a 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add click listeners - open settings
f0d3bf4 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add click listeners - open status
9f91144 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
show red badge when actionsRequired
c1481c1 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
fix duplicate accounts
2fa56af 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
status should be display first
2eac6b9 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
format
2fa47e5 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
implementing MVVM and coroutines
6f02663 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add repo in RepositoryModule
56270be 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
update ViewModelModule
2387874 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
using composable with MVVM and coroutines
d13fe4a 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
show accounts first and then apply badge if pending invitations are p…
9deea61 
…resent

Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
update header
680e2a0 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
ktlintFormat
5d9051d 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add header
cdd95e6 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
merge conflicts
08bf6f8 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
split status
0043ee3 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
use tag
cb3aab0 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
create data class - AccountItem
f5bfcd2 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add license header info
e9f120d 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
some more improvements to UI
4b6b05b 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
some more improvements to UI
e2fb0e2 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
format code
3f8c76e 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
format code
a71d246 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
fix build
4c98bbb 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
fix lint
2f3badc 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
fix detekt
bfc25a7 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
remove choose account xml file
979ce16 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
some UI changes
0a2dec0 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
small layout changes
b14fe2e 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
show settings option when there is no internet connection
53cd86b 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from f30b5b0 to 53cd86b Compare October 8, 2025 08:13
@mahibi
Copy link
Collaborator

mahibi commented Oct 8, 2025

Can you squash into one commit?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Codacy

Lint

TypemasterPR
Warnings99100
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1110
Dodgy code6254
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total9081

Lint increased!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5227.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nickvergessen
Copy link
Member

nickvergessen commented Oct 13, 2025 •
edited
Loading

Can you squash into one commit?

Let's save the time here if it's too complicated.
If we can deduplicate/merge commits with the same name or purpose, it of course makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

@mahibi mahibi Awaiting requested review from mahibi

Requested changes must be addressed to merge this pull request.

Assignees

@sowjanyakch sowjanyakch

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve ChooseAccountDialogFragment

3 participants

@sowjanyakch @mahibi @nickvergessen