Skip to content

Refactoring Login Process to MVVM #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactoring Login Process to MVVM #5523

wants to merge 2 commits into from
+73 −316

Conversation

@rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Oct 31, 2025

🖼️ Screenshots

Screen_recording_20251031_113012.webm

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Oct 31, 2025
@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Oct 31, 2025
@rapterjet2004 rapterjet2004 requested a review from mahibi October 31, 2025 16:33
@rapterjet2004 rapterjet2004 mentioned this pull request Nov 3, 2025
Open
mahibi
mahibi requested changes Nov 13, 2025
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when trying to login with loginv2 it fails:

2025-11-13 11:48:17.326  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  []
2025-11-13 11:48:17.327  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  <-- END HTTP (2-byte body)
2025-11-13 11:48:17.586  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  --> POST https://sermo.nextcloud.com/login/v2/poll
2025-11-13 11:48:17.587  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  Content-Type: application/x-www-form-urlencoded
2025-11-13 11:48:17.587  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  Content-Length: 134
2025-11-13 11:48:17.587  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  User-Agent: Mozilla/5.0 (Android) Nextcloud-Talk v23.0.0 Alpha 13
2025-11-13 11:48:17.588  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  Accept: application/json
2025-11-13 11:48:17.588  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  OCS-APIRequest: true
2025-11-13 11:48:17.589  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  ngrok-skip-browser-warning: true
2025-11-13 11:48:17.590  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  token=shtYa8ErLZZzeDaxg0QugStgLmki0w0Cs6R8UHuZR8dUlli1qsdzMUIsSU1saccRpghhhz4xlI0N7ix0jXvjxTZJRWybggMIqkBuo9f8OvqSxmtBBQrx2ip9w95mcgyx
2025-11-13 11:48:17.590  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  --> END POST (134-byte body)
2025-11-13 11:48:17.725  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  <-- 404 https://sermo.nextcloud.com/login/v2/poll (134ms)
2025-11-13 11:48:17.726  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  server: nginx
2025-11-13 11:48:17.726  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  date: Thu, 13 Nov 2025 10:48:17 GMT
2025-11-13 11:48:17.726  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  content-type: application/json; charset=utf-8
2025-11-13 11:48:17.726  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  content-length: 2
2025-11-13 11:48:17.726  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-request-id: NZgq7ENSbyU2iA4nE9t2
2025-11-13 11:48:17.727  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  cache-control: no-cache, no-store, must-revalidate
2025-11-13 11:48:17.727  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  content-security-policy: default-src 'none';base-uri 'none';manifest-src 'self';frame-ancestors 'none'
2025-11-13 11:48:17.727  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  feature-policy: autoplay 'none';camera 'none';fullscreen 'none';geolocation 'none';microphone 'none';payment 'none'
2025-11-13 11:48:17.727  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-robots-tag: noindex, nofollow
2025-11-13 11:48:17.728  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  strict-transport-security: max-age=15768000; includeSubDomains; preload
2025-11-13 11:48:17.728  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  referrer-policy: no-referrer
2025-11-13 11:48:17.728  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-content-type-options: nosniff
2025-11-13 11:48:17.728  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-frame-options: SAMEORIGIN
2025-11-13 11:48:17.729  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-permitted-cross-domain-policies: none
2025-11-13 11:48:17.729  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-robots-tag: noindex, nofollow
2025-11-13 11:48:17.729  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-xss-protection: 1; mode=block
2025-11-13 11:48:17.731  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  []
2025-11-13 11:48:17.731  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  <-- END HTTP (2-byte body)
2025-11-13 11:48:17.993  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  --> POST https://sermo.nextcloud.com/login/v2/poll
2025-11-13 11:48:17.995  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  Content-Type: application/x-www-form-urlencoded
2025-11-13 11:48:17.995  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  Content-Length: 134
2025-11-13 11:48:17.996  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  User-Agent: Mozilla/5.0 (Android) Nextcloud-Talk v23.0.0 Alpha 13
2025-11-13 11:48:17.996  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  Accept: application/json
2025-11-13 11:48:17.996  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  OCS-APIRequest: true
2025-11-13 11:48:17.996  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  ngrok-skip-browser-warning: true
2025-11-13 11:48:17.998  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  token=shtYa8ErLZZzeDaxg0QugStgLmki0w0Cs6R8UHuZR8dUlli1qsdzMUIsSU1saccRpghhhz4xlI0N7ix0jXvjxTZJRWybggMIqkBuo9f8OvqSxmtBBQrx2ip9w95mcgyx
2025-11-13 11:48:17.998  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  --> END POST (134-byte body)
2025-11-13 11:48:18.021  8961-9189  okhttp.OkHttpClient     com.nextcloud.talk2                  I  <-- HTTP FAILED: java.net.UnknownHostException: Unable to resolve host "sermo.nextcloud.com": No address associated with hostname
2025-11-13 11:48:18.022  8961-9189  NetworkLoginDataSource  com.nextcloud.talk2                  E  Error caught at performLoginFlowV2: java.net.UnknownHostException: Unable to resolve host "sermo.nextcloud.com": No address associated with hostname
2025-11-13 11:48:35.019  8961-9216  HWUI                    com.nextcloud.talk2                  I  setGrContext validptr-->nullptr

@rapterjet2004
WIP - loginNormally is now broken into 2 parts, both starting executi…
5cda275 
…on from the app instead of running in the background

Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 requested a review from mahibi November 18, 2025 17:29
@rapterjet2004
Copy link
Contributor Author

rapterjet2004 commented Nov 18, 2025 •
edited
Loading

Not sure what exactly was causing it, because the error message seems to be misleading, but I had a hunch the poolLogin function was calling the API from the background, which maybe requires foreground or service permissions. So I broke the loginNormally function into 2 parts, loginNormally executes before the browser is launched and loginNormally2 executes after the user returns to the app. This seems to fix the error.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5523.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@mahibi mahibi requested a review from sowjanyakch November 24, 2025 10:11
@mahibi
Copy link
Collaborator

mahibi commented Nov 24, 2025

Not sure what exactly was causing it, because the error message seems to be misleading, but I had a hunch the poolLogin function was calling the API from the background, which maybe requires foreground or service permissions. So I broke the loginNormally function into 2 parts, loginNormally executes before the browser is launched and loginNormally2 executes after the user returns to the app. This seems to fix the error.

It works for me. I would prefer clearer names for loginNormally2 and loginNormally2.
Maybe startWebBrowserLogin and handleWebBrowserLogin ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Requested changes must be addressed to merge this pull request.

Assignees

@rapterjet2004 rapterjet2004

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor the login process in MVVM

3 participants

@rapterjet2004 @mahibi