Bugfix/noid/improve notification handling #5565
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
when notificationUser is not known (because get NC notification failed), do not style notification with avatar not show mark as read not show reply action ... these things will need infos from NC notification! Signed-off-by: Marcel Hibbe <[email protected]>
... the ugly "fallback" icons should not be shown in this case Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
bugfix/noid/improveNotificationHandling
branch
from
c268721 to
78383fa
Compare
Contributor
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5565.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When push notification was received but NC server was not available, no notification was shown (Should be an edge case but might fix 'some' missing notifications).
If fetching of notification info from NC server fails, the decrypted subject from the push notification itself is used. In this case less features are available (no avatar, no inline reply, no "mark as read").
For testing, e.g. just replace the url in
getUrlForNcNotificationWithIdmethod.Should be further improved in followup PRs by:
🏁 Checklist
/backport to stable-xx.x