Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5567.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@mahibi
Copy link
Collaborator

mahibi commented Nov 21, 2025

Thanks Tobias!
I did not test but this should solve it.

However do we need

val userId: String?

inside AccountItem at all?

It's confusing that the userId it saved twice so it can be accessed via:

user.userId
and
user.user.userId

?

The PR should fix the issue caused by

addAccountToList(user, user.userId ?: user.username, pendingCount)

but it feels more like a workaround while the main issue is not solved: why can userId be null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants